Author Topic: mod pi-stomp service reboot loop with some pedals  (Read 819 times)

dormir

  • Newbie
  • *
  • Posts: 8
    • View Profile
mod pi-stomp service reboot loop with some pedals
« on: March 12, 2022, 06:44:43 PM »
heya,

recently I deleted all the factory presets and just only 1 pedalboard for a while, now I've added more boards again to test out different things and my pistomp went a bit crazy, the boards and audio seems to work just fine, but the screen constantly displays white and pistomp in alternation and the controls dont work anymore... i ran ps-journal to see what's going on:

Code: [Select]
Mar 13 00:33:20 greytree systemd[1]: Started MOD-ALA-PI-STOMP.
Mar 13 00:33:22 greytree python3[21046]: Traceback (most recent call last):
Mar 13 00:33:22 greytree python3[21046]:   File "/home/patch/pi-stomp/modalapistomp.py", line 147, in <module>
Mar 13 00:33:22 greytree python3[21046]:     main()
Mar 13 00:33:22 greytree python3[21046]:   File "/home/patch/pi-stomp/modalapistomp.py", line 89, in main
Mar 13 00:33:22 greytree python3[21046]:     handler.load_pedalboards()
Mar 13 00:33:22 greytree python3[21046]:   File "/home/patch/pi-stomp/modalapi/mod.py", line 443, in load_pedalboards
Mar 13 00:33:22 greytree python3[21046]:     pedalboard.load_bundle(bundle, self.plugin_dict)
Mar 13 00:33:22 greytree python3[21046]:   File "/home/patch/pi-stomp/modalapi/pedalboard.py", line 175, in load_bundle
Mar 13 00:33:22 greytree python3[21046]:     category = cat[0]
Mar 13 00:33:22 greytree python3[21046]: IndexError: list index out of range
Mar 13 00:33:22 greytree systemd[1]: mod-ala-pi-stomp.service: Main process exited, code=exited, status=1/FAILURE
Mar 13 00:33:22 greytree systemd[1]: mod-ala-pi-stomp.service: Failed with result 'exit-code'.
Mar 13 00:33:24 greytree systemd[1]: mod-ala-pi-stomp.service: Service RestartSec=2s expired, scheduling restart.
Mar 13 00:33:24 greytree systemd[1]: mod-ala-pi-stomp.service: Scheduled restart job, restart counter is at 200.
Mar 13 00:33:24 greytree systemd[1]: Stopped MOD-ALA-PI-STOMP.

well, this goes on... so then i've checked in with pedalboard.py on line 175, didn't dig in too deep, but it seemed to me it relates to some information that gets pulled from the individual plugins, so then i randomly removed a few pedals on different boards and it went back to normal operation.

in this case it was the Mayank Granulator pedal that caused this issue. is there some way to mitigate this issue? are there known plugins which cause it and why?

best,
dormir

dormir

  • Newbie
  • *
  • Posts: 8
    • View Profile
Re: mod pi-stomp service reboot loop with some pedals
« Reply #1 on: March 14, 2022, 09:04:00 AM »
heya,

sorry for double posting, but I think I made a little headway with this issue. What's pretty obvious is that it seems to relate to the creation of the interface on the pistomp screen and that is not able load some information. I've tried adding random stuff from the .ttl files of plugins that are working to the .ttl files of plugins that aren't working and it seems to fix the issue, but I have not completely understood which information is necessary for the pistomp-ui.

is category/ cat[0] thing the plugin category? lv2:ReverbPlugin for example, or does it refer to something else? maybe someone who is more knowledgeable can tell me which pieces of information the pistomp ui needs to build itself.

best,
dormir

Randall (Admin)

  • Administrator
  • Full Member
  • *****
  • Posts: 221
    • View Profile
Re: mod pi-stomp service reboot loop with some pedals
« Reply #2 on: March 14, 2022, 09:57:52 PM »
Thanks for finding that bug.  It's due to a plugin having an empty Category field.  The code was testing for it to be not None, but it could be not None and still be empty.

I filed this issue:
https://github.com/TreeFallSound/pi-stomp/issues/32

and resolved it.

To get the fix you can:
cd /home/patch/pi-stomp
git pull

Or you could add the one-line fix yourself.  It's line 174 of modalapi/pedalboard.py, which should now look like:
if cat is not None and len(cat) > 0:

dormir

  • Newbie
  • *
  • Posts: 8
    • View Profile
Re: mod pi-stomp service reboot loop with some pedals
« Reply #3 on: March 15, 2022, 06:55:23 AM »
very cool that it's such a simple fix. now i can fill up my pedalboards with all those not properly categorized plugins. thanks randall!