Taking out ttymidi

[benh]

Hi !

I noticed ttymidi is eating CPU in the background on my system where I didn't wire any MIDI ports to the UART.

I'll send a PR making the installation of the ttymidi related components optional in setup.sh (default on or off ? for now it's default without and -m adds midi but I can change it before I submit). That said, before I do that, am I missing anything in pistomp itself that relies on ttymidi being present ? I didn't notice anything on my side but I could have missed something.

Another option could be to always install it but make the enabling of the service optional.

[Randall (Admin)]

It's a prereq for patchbox.  I'm near certain is not required for USB midi or the midi events generated by pi-Stomp hardware.  I don't know what other functions might rely on it, though.

We could likely disable it by default and include instructions in the wiki on how to enable it where adding serial midi is explained.

I do not like the idea having certain parts of the total install optional though.  Disk space is cheap and plentyful.  Different users having different installations leads to more support calls which I wouldn't care for. 

[benh]

Yes I tend to side with you on that one, I'll keep the install and just skip the enabling of the service by default unless specified